Changeset 388 for trunk/ICeCoffEE/ICeCoffEE/ICeCoffEE.m

Timestamp:

02/22/08 19:53:07 (16 years ago)

Author:

Nicholas Riley

Message:

APEMain.m: Note missing Xcode 3 support. Add Terminal 2.0 support.

English.lproj/APE Manager plugin.nib:

English.lproj/APEInfo.rtfd:

ICeCoffEE.[hm]: Bring triggering window and app to front if error
dialog displayed in ICCF_HandleException. Remove initial word
selection. Launch preexisting selection if present. Remove 10.3
support. Update for new ICeCoffEETrigger API. Rename downEvent
parameter for consistency.

ICeCoffEE.xcodeproj: Added files.

ICeCoffEEParser.m: Handle multiline URLs.

ICeCoffEETTView.[hm]: Terminal 2.0 support (thank you for having a
usable NSTextInput implementation!)

ICeCoffEETTViewTrigger.[hm]: ICeCoffEETrigger implementation for
TTView. Can't set range as we do for NSTextView because you can't
have an arbitrary empty selection range in Terminal, so we pass it
directly to ICCF_LaunchURLFromTTView.

ICeCoffEETerminal.[hm]: Fix capitalization on ICeCoffEETermSubviewSuper.
Pass downEvent to ICCF_HandleException so it can bring the triggering
window to the front.

ICeCoffEETextViewTrigger.[hm]: Moved from ICeCoffEETrigger.

ICeCoffEETrigger.[hm]: Now an abstract superclass. Replace direct
access to ICCF_sharedTrigger with +cancel. Create 0-character range
(if click outside selectedRange) or save selectedRange. Move
debugging logs here from ICeCoffEE.m. Add description method.

ICeCoffEEWebKit.m: Pass downEvent to ICCF_HandleException so it can
bring the triggering window to the front.

Installer components/ui/ui.plist: Updated for 1.5d3.

TestParser.m: Handle multiline URLs; newlines are printed as \ and
tabs as >. Implement ICCF_StringByRemovingCharactersInSet, which will
move elsewhere once Internet Config support is removed.

VERSION.xcconfig: Updated for 1.5d3.

urls.plist: Test for multiline URLs.

File:

• trunk/ICeCoffEE/ICeCoffEE/ICeCoffEE.m (modified) (7 diffs)

trunk/ICeCoffEE/ICeCoffEE/ICeCoffEE.m

@@ -7 +7 @@
 #import "ICeCoffEESuper.h"
 #import "ICeCoffEEServices.h"
-#import "ICeCoffEETrigger.h"
+#import "ICeCoffEETextViewTrigger.h"
 #import "ICeCoffEEParser.h"
 
@@ -190 +190 @@
 Boolean ICCF_enabled = true;
 
-BOOL ICCF_HandleException(NSException *e) {
+BOOL ICCF_HandleException(NSException *e, NSEvent *event) {
     if ([e reason] == nil || [[e reason] length] == 0)
         return NO;
@@ -196 +196 @@
     if (ICCF_prefs.errorSoundEnabled) NSBeep();
     if (!ICCF_prefs.errorDialogEnabled) return YES;
+    
+    [[NSApplication sharedApplication] activateIgnoringOtherApps: YES];
+    [[event window] makeKeyAndOrderFront: nil];
     
     int result = NSRunAlertPanel(ICCF_LocalizedString(@"AlertTitle"), ICCF_LocalizedString(@"AlertMessage%@"), nil, nil, ICCF_LocalizedString(@"AlertDisableButton"), e);
@@ -208 +211 @@
 
 void ICCF_LaunchURLFromTextView(NSTextView *self, NSEvent *triggeringEvent) {
-    NSRange range = [self selectedRange];
     NSColor *insertionPointColor = [self insertionPointColor];
-    NSString *s = [[self textStorage] string]; // according to the class documentation, sending 'string' is guaranteed to be O(1)
-    int i;
 
     NS_DURING
 
+        NSString *s = [[self textStorage] string]; // according to the class documentation, sending 'string' is guaranteed to be O(1)
+        unsigned length = [s length];
+        NSCAssert(s != nil, ICCF_LocalizedString(@"Sorry, ICeCoffEE is unable to locate the insertion point or selection"));
+        NSCAssert(length != 0, ICCF_LocalizedString(@"No text was found"));
+
+        ICCF_StartIC();
+
+        NSRange range = [self selectedRange];
         NSCAssert(range.location != NSNotFound, ICCF_LocalizedString(@"There is no insertion point or selection in the text field where you clicked"));
-        NSCAssert(s != nil, ICCF_LocalizedString(@"Sorry, ICeCoffEE is unable to locate the insertion point or selection"));
-
-        ICCF_StartIC();
-
-        NSCAssert([s length] != 0, ICCF_LocalizedString(@"No text was found"));
-
-        if (range.location == [s length]) range.location--; // work around bug in selectionRangeForProposedRange (r. 2845418)
-
-        // XXX is this even worth it to get a starting range?  Can just grab back and forth ICCF_MAX_URL_LEN (will need to remove some ICCF_CheckRange calls though)
-        range = [self selectionRangeForProposedRange: range granularity: NSSelectByWord];
-
-        // However, NSSelectByWord does not capture even the approximate boundaries of a URL
-        // (text to a space/line ending character); it'll stop at a period in the middle of a hostname.
-        // So, we expand it as follows:
-        
-        range = ICCF_URLEnclosingRange(s, range);
-
-        [self setSelectedRange: range affinity: NSSelectionAffinityDownstream stillSelecting: NO];
-        [self display];
+    
+        if (range.length == 0) {
+            if (range.location == length) range.location--;
+            range.length = 1;
+            range = ICCF_URLEnclosingRange(s, range);
+            [self setSelectedRange: range affinity: NSSelectionAffinityDownstream stillSelecting: NO];
+        }
 
         if (ICCF_LaunchURL([s substringWithRange: range], ICCF_KeyboardAction(triggeringEvent)) && ICCF_prefs.textBlinkEnabled) {
-            for (i = 0 ; i < ICCF_prefs.textBlinkCount ; i++) {
+            for (unsigned i = 0 ; i < ICCF_prefs.textBlinkCount ; i++) {
                 NSRange emptyRange = {range.location, 0};
                 [self setSelectedRange: emptyRange affinity: NSSelectionAffinityDownstream stillSelecting: YES];
@@ -250 +246 @@
 
     NS_HANDLER
-        ICCF_HandleException(localException);
+        ICCF_HandleException(localException, triggeringEvent);
     NS_ENDHANDLER
 
@@ -418 +414 @@
 }
 
-- (void)mouseDown:(NSEvent *)e;
+- (void)mouseDown:(NSEvent *)downEvent;
 {
 #if ICCF_DEBUG
@@ -427 +423 @@
     }
     down = YES;
-    ICLog(@"ICeCoffEE down: %@", e);
+    ICLog(@"ICeCoffEE down: %@", downEvent);
 #endif
-    if (ICCF_sharedTrigger != nil) {
-        ICLog(@"%@ cancelling", ICCF_sharedTrigger);
-        [ICCF_sharedTrigger cancel];
-    }
-    if (ICCF_enabled && ICCF_prefs.commandClickEnabled && ICCF_EventIsCommandMouseDown(e)) {
-        BOOL inheritModifierFlags;
-        if ([self respondsToSelector: @selector(selectedRanges)]) {
-            // Command-multiple-click or -drag for discontiguous selection, Mac OS X 10.4 or later
-            inheritModifierFlags = YES;
-        } else {
-            // don't want to trigger selection extension or anything else; pass through as a plain click
-            // (on Mac OS X 10.3, command does not modify behavior)
-            inheritModifierFlags = NO;
-        }
-        [super mouseDown: ICCF_MouseDownEventWithModifierFlags(e, inheritModifierFlags)];
+    [ICeCoffEETrigger cancel];
+
+    if (ICCF_enabled && ICCF_prefs.commandClickEnabled && ICCF_EventIsCommandMouseDown(downEvent)) {
+        [super mouseDown: ICCF_MouseDownEventWithModifierFlags(downEvent, YES)];
         // we don't actually get a mouseUp event, just wait for mouseDown to return
         NSEvent *upEvent = [[self window] currentEvent];
-        NSPoint downPt = [e locationInWindow];
+        NSPoint downPt = [downEvent locationInWindow];
         NSPoint upPt = [upEvent locationInWindow];
         ICLog(@"next: %@", upEvent);
         NSAssert([upEvent type] == NSLeftMouseUp, @"NSTextView mouseDown: did not return with current event as mouse up!");
         if (abs(downPt.x - upPt.x) <= kICHysteresisPixels && abs(downPt.y - upPt.y) <= kICHysteresisPixels) {
-            if (inheritModifierFlags) {
-                // Mac OS X 10.4 and later: make sure we don't have a command-double-click
-                [ICeCoffEETrigger setTriggerForEvent: e onTarget: self]; // gets stored in ICCF_sharedTrigger; the reason for this weird calling pattern is that we don't want to add methods to NSTextView, and we don't want to add a method call on every mouseDown
-                ICLog(@"%@ set", ICCF_sharedTrigger);
-            } else {
-                // Mac OS X 10.3
-                ICCF_LaunchURLFromTextView(self, e);
-            }
+            // make sure we don't have a Command-double-click
+            [ICeCoffEETextViewTrigger setTriggerForEvent: downEvent onTarget: self]; // gets stored in ICCF_sharedTrigger; the reason for this weird calling pattern is that we don't want to add methods to NSTextView, and we don't want to add a method call on every mouseDown
         }
     } else {
-        [super mouseDown: e];
+        [super mouseDown: downEvent];
     }
 #if ICCF_DEBUG