Changeset 561 for trunk/Cocoa

Timestamp:

07/18/09 06:00:31 (15 years ago)

Author:

Nicholas Riley

Message:

PSSpeechAlert.m: Remove memory leak when voice not found; note that even this behavior isn't ideal.

File:

• trunk/Cocoa/Pester/Source/PSSpeechAlert.m (modified) (1 diff)

trunk/Cocoa/Pester/Source/PSSpeechAlert.m

@@ -72 +72 @@
 {
     NSMutableDictionary *plAlert = [[super propertyListRepresentation] mutableCopy];
-    if (voice == nil)
+    if (voice == nil) {
+        // XXX should pick a different voice, not destroy the alert
+        [plAlert release];
         @throw [NSException exceptionWithName: NSInvalidArgumentException
                                        reason: @"The selected voice is not available." userInfo: nil];
+    }
     [plAlert setObject: voice forKey: PLAlertVoice];
     return [plAlert autorelease];