Changeset 51 for trunk/Cocoa/Pester/Source/PSAlarmsController.m

Timestamp:

11/18/02 08:57:41 (21 years ago)

Author:

Nicholas Riley

Message:

Alarms.nib: Removed horizontal scroll bar. Turned on grid. Set delegate to NJRTableDelegate instead of PSAlarmSetController.

NJRTableDelegate: In general, made functional (was previously unused). Fixed MyCompanyName. Changed ORDER_BY_CONTEXT to use key-value coding instead of assuming data consists of a dictionary of dictionaries. Added sorting support (reorderedData, replaces oData) with autosave support for sort context. Added _positionTypeSelectDisplay, which adjusts position and justification of type select display control based on the current sort column. Added support for reverse sorting in type select string. Use table data source instead of sorted data so text matches as displayed (this will break with non-text cells...).

NJRTableView: Adapted from iTableView (Jaguar table alternate table background color), TableTester (most everything else) and NJROutlineView (keyDown, moveToBeginning/EndOfDocument). Support for type selection, delete shortcut for row deletion, and iTunes-alike background colors and frame.

NSCharacterSet-NJRExtensions: Moved _typeSelectSet from NJROutlineView as it's now shared with NJRTableView. Still need to factor NJROutlineView as embedded in HostLauncher some day.

PSAlarm: Reorganized, renamed and categorized methods. Added time accessor for the benefit of sorting. Renamed compare: to compareDate: for clarity. Added compareMessage:, though it's currently unused. Renamed cancel to cancelTimer for clarity.

PSAlarmSetController: More fun with initial first responder on window show/hide; still need to work around bug properly (subclass NSComboBox?) and fix it for real. As is, works for OS X 10.1.

PSAlarms: Added alarms accessor, returning alarm array. Fixed memory leak on successful alarm removal (oops). Added removeAlarms:, needed with sorted alarm list.

PSAlarmsController: Set window resize increment. Changes to table delegate methods to use reordered alarm list. Register for NSTableViewSelectionDidChangeNotification now we're no longer the table view delegate. Fixed autoselection in alarmsChanged by using data reordering support in NJRTableView. Implement NJRTableViewDataSource to permit deletion from table view.

Pester.pbproj: Added new files.

Read Me.rtfd: Added TableTester/iTableView acknowledgements. Updated release notes.

File:

• trunk/Cocoa/Pester/Source/PSAlarmsController.m (modified) (4 diffs)

trunk/Cocoa/Pester/Source/PSAlarmsController.m

@@ -10 +10 @@
 #import "PSAlarm.h"
 #import "NSTableView-NJRExtensions.h"
-
+#import "NJRTableView.h"
+#import "NJRTableDelegate.h"
 
 @implementation PSAlarmsController
+
+- (void)alarmsChanged;
+{
+    reorderedAlarms = [[tableView delegate] reorderedDataForData: [alarms alarms]];
+}
 
 - (id)init;
@@ -23 +29 @@
         if (nil == [[NSUserDefaults standardUserDefaults] objectForKey:
             [@"NSWindow Frame " stringByAppendingString: [[self window] frameAutosaveName]]])
-        {
+           {
             [[self window] center];
-        }
+           }
         [[NSNotificationCenter defaultCenter] addObserver: self selector: @selector(alarmsChanged) name: PSAlarmsDidChangeNotification object: alarms];
+        [[NSNotificationCenter defaultCenter] addObserver: self selector: @selector(tableViewSelectionDidChange:) name: NSTableViewSelectionDidChangeNotification object: tableView];
         [tableView setAutosaveName: @"Alarm list"];
         [tableView setAutosaveTableColumns: YES];
-        [tableView noteNumberOfRowsChanged];
+        [self alarmsChanged];
         [[self window] makeFirstResponder: tableView];
+        [[self window] setResizeIncrements: NSMakeSize(1, [tableView cellHeight])];
     }
     return self;
 }
 
-- (void)alarmsChanged; // XXX fix autoselection to be more reasonable, see whatever I did in that _Learning Cocoa_ project I think
-{
-    [tableView reloadData];
-    [tableView deselectAll: self];
-}
 
 - (IBAction)remove:(id)sender;
 {
-    [alarms removeAlarmsAtIndices: [[tableView selectedRowEnumerator] allObjects]];
+    [alarms removeAlarms: [[tableView delegate] selectedItems]];
 }
 
@@ -57 +60 @@
 - (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(int)row;
 {
-    PSAlarm *alarm = [alarms alarmAtIndex: row];
+    PSAlarm *alarm = [reorderedAlarms objectAtIndex: row];
 
     if ([[tableColumn identifier] isEqualToString: @"message"]) return [alarm message];
@@ -70 +73 @@
     return nil;
 }
+@end
+
+@implementation PSAlarmsController (NJRTableViewDataSource)
+
+- (void)removeSelectedRowsFromTableView:(NSTableView *)aTableView;
+{
+    [self remove: aTableView];
+}
+
 @end