Changeset 357 for trunk/Cocoa

Timestamp:

11/23/07 23:50:00 (17 years ago)

Author:

Nicholas Riley

Message:

PSAlarms.m: Fix leak of restored alarms.

File:

• trunk/Cocoa/Pester/Source/PSAlarms.m (modified) (2 diffs)

trunk/Cocoa/Pester/Source/PSAlarms.m

@@ -274 +274 @@
         e = [plPendingAlarms objectEnumerator];
         while ( (plAlarm = [e nextObject]) != nil) {
-            [alarms addObject: [[PSAlarm alloc] initWithPropertyList: plAlarm]];
+            alarm = [[PSAlarm alloc] initWithPropertyList: plAlarm];
+            [alarms addObject: alarm];
+            [alarm release];
         }
 
@@ -280 +282 @@
         while ( (plAlarm = [e nextObject]) != nil) {
             // expired alarms may be ready for deletion, or may repeat - if the latter, PSAlarm will reschedule the alarm so the repeat interval begins at restoration time. 
-            if ( (alarm = [[PSAlarm alloc] initWithPropertyList: plAlarm]) != nil)
+            if ( (alarm = [[PSAlarm alloc] initWithPropertyList: plAlarm]) != nil) {
                 [alarms addObject: alarm];
+                [alarm release];
+            }
         }
         expiredAlarms = [[NSMutableSet alloc] init];