Changeset 333

Timestamp:

08/09/07 09:03:58 (17 years ago)

Author:

Nicholas Riley

Message:

AntiRSI.[hm]: Replaced unnecessary use of KVO on reset_session_timer_time with setReset_session_timer_time; now reset_session_timer_time is a NSCalendarDate that doesn't need converting every time it's used. Invalidate badge_session_minutes so the badge changes when the work color is adjusted in preferences.

Location:

trunk/Cocoa/AntiRSI

Files:

• AntiRSI.h (modified) (1 diff)
• AntiRSI.m (modified) (6 diffs)

trunk/Cocoa/AntiRSI/AntiRSI.h

@@ -87 +87 @@
     bool reset_session_timer_daily;
     bool reset_session_timer_after;
-    NSDate *reset_session_timer_time;
+    NSCalendarDate *reset_session_timer_time;
     int reset_session_timer_after_hours;
         

trunk/Cocoa/AntiRSI/AntiRSI.m

@@ -26 +26 @@
 extern CFTimeInterval CGSSecondsSinceLastInputEvent(unsigned long eventType);
 
+static int badge_session_minutes = -1;
+
 @implementation AntiRSI
+
+- (void)computeResetSessionDate;
+{
+    NSCalendarDate *now = [NSCalendarDate calendarDate];
+    NSCalendarDate *reset =
+        [NSCalendarDate dateWithYear:[now yearOfCommonEra]
+                               month:[now monthOfYear]
+                                 day:[now dayOfMonth]
+                                hour:[reset_session_timer_time hourOfDay]
+                              minute:[reset_session_timer_time minuteOfHour]
+                              second:0
+                            timeZone:[NSTimeZone systemTimeZone]];
+    if ([now compare:reset] != NSOrderedAscending)
+        reset = [reset dateByAddingYears:0 months:0 days:1 hours:0 minutes:0 seconds:0];
+    reset_session_date = [reset timeIntervalSinceReferenceDate];
+}
 
 // bindings methods
@@ -53 +71 @@
 {       work_break_period = 60 * round(f); }
 
+- (void)setReset_session_timer_time:(NSDate *)d;
+{
+    if (reset_session_timer_time != nil)
+        [reset_session_timer_time autorelease];
+    reset_session_timer_time = [[NSCalendarDate alloc] initWithTimeIntervalSinceReferenceDate:[d timeIntervalSinceReferenceDate]];
+    [reset_session_timer_time setTimeZone:[NSTimeZone timeZoneForSecondsFromGMT:0]];
+    [self computeResetSessionDate];
+}
+
 - (void)installTimer:(double)interval
 {
@@ -103 +130 @@
         elapsed=[c retain];
     [dock_badge setBadgeColor:elapsed];
+    badge_session_minutes = -1;
         [self drawDockImage];
 }
@@ -225 +253 @@
         [self bind:@"background" toObject:dc withKeyPath:@"values.background" options:unarchive];
     
-    // watch for timer changes
-    [dc addObserver:self forKeyPath:@"values.reset_session_timer_time" options:0 context:NULL];
-    
         // alert every binding
         [dc revert:self];
@@ -236 +261 @@
         // about dialog
         [version setStringValue:[NSString stringWithFormat:@"Version %@", sVersion]]; 
-}
-
-- (void)computeResetSessionDate;
-{
-    NSTimeZone *systemZone = [NSTimeZone systemTimeZone];
-    NSCalendarDate *today = [NSCalendarDate calendarDate];
-    NSCalendarDate *reset = [NSCalendarDate dateWithTimeIntervalSinceReferenceDate:[reset_session_timer_time timeIntervalSinceReferenceDate]];
-    [reset setTimeZone:[NSTimeZone timeZoneForSecondsFromGMT:0]];
-    reset = [NSCalendarDate dateWithYear:[today yearOfCommonEra]
-                                   month:[today monthOfYear]
-                                     day:[today dayOfMonth]
-                                    hour:[reset hourOfDay]
-                                  minute:[reset minuteOfHour]
-                                  second:0
-                                timeZone:systemZone];
-    if ([today compare:reset] != NSOrderedAscending)
-        reset = [reset dateByAddingYears:0 months:0 days:1 hours:0 minutes:0 seconds:0];
-    reset_session_date = [reset timeIntervalSinceReferenceDate];
-}
-
-- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context;
-{
-    if ([keyPath isEqualToString:@"values.reset_session_timer_time"])
-        [self computeResetSessionDate];
 }
 
@@ -534 +535 @@
     if (draw_dock_badge) {
         static NSImage *badge = nil;
-        static int badge_session_minutes = -1;
         int session_minutes = (int)session_t / 60;
         if (badge_session_minutes != session_minutes) {