Changeset 222 for trunk/Cocoa/F-Script Anywhere/Source/FSAAppList.m

Timestamp:

05/16/06 18:44:19 (18 years ago)

Author:

rchin

Message:

Fixed problem with F-Script leaking file handles (caused F-Script to not be able to inject into applications after a certain number of running apps had been launched). The problem was in appIsPEF calling open(2) but not close(2) before returning.

File:

• trunk/Cocoa/F-Script Anywhere/Source/FSAAppList.m (modified) (5 diffs)

trunk/Cocoa/F-Script Anywhere/Source/FSAAppList.m

@@ -132 +132 @@
 {
     [tableView reloadData];
-    [self tableView: tableView shouldSelectRow: [tableView selectedRow]];
+//    [self tableView: tableView shouldSelectRow: [tableView selectedRow]];
 }
 
@@ -143 +143 @@
 {
     DeVercruesseProcess *app = [self _applicationForPID: pid];
-    [patchingApps removeObject: app];
-    [patchedApps addObject: app];
+    if(app){
+        [patchingApps removeObject: app];
+        [patchedApps addObject: app];
+    }
     [self _processStatusChanged];
 }
@@ -170 +172 @@
         return NO;
     
-    if (read(fd, &pefHeader, sizeof(pefHeader)) != sizeof(pefHeader))
+    if (read(fd, &pefHeader, sizeof(pefHeader)) != sizeof(pefHeader)){
+        close(fd);
         return NO;
+    } else
+        close(fd);
     
     if (pefHeader.tag1 != kPEFTag1 || pefHeader.tag2 != kPEFTag2)
@@ -229 +234 @@
      }
      */
-    
     if ( ![app isBackgroundOnly] &&
          ( ( [app isCocoa] && ![self appIsPEF: app]) ||
@@ -461 +465 @@
     id e = [cocoaApps objectEnumerator];
     while(anApp = [e nextObject]){
-        if([alwaysApps containsObject:[anApp name]] && ![patchedApps containsObject:anApp]){
+        if([alwaysApps containsObject:[anApp name]]){
             [NSApp installBundleInAppWithPID:[anApp pid]];
         }