Changeset 182 for trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEServicePrefController.m

Timestamp:

05/14/05 02:47:12 (19 years ago)

Author:

Nicholas Riley

Message:

English.lproj/APEInfo.rtfd: Partial documentation update for 1.4.2;
fixed many instances of outdated and incorrect information.

ICeCoffEE.m: Removed completed "to do" comments - that's what
OmniOutliner and Trac are for. Fixed delimiters to make more sense.
Redid ICCF_ParseURL() to make more sense and strip invalid characters
from beginning of URL. Added note about deprecated getCString:.
Fixed ICCF_ServicesMenuItem() to work on Tiger; moved menu population
logic (where services menu delegate used) to new
ICCF_SetServicesMenu() in ICeCoffEESetServicesMenu.[hm]. Remove key
equivalents from services in ICCF_ConsolidateServicesMenu(). First
pass at a workaround for discontiguous selection: only trigger if
there is no selection. This will be fixed to use a timer.

ICeCoffEEServicePrefController: Fixed service population to work on
Tiger, though keyboard equivalents are not provided; will need to
switch to parsing output of CFServiceControllerCopyServicesEntries()
for that one.

ICeCoffEEWebKit.m: Removed Safari 1.0-1.2 support. Fixed incorrect
comment about -selectionRect only being in Safari
1.1-1.2.

ICeCoffEESetServicesMenu.[hm]: Handle getting a usable services menu
for Panther and Tiger.

File:

• trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEServicePrefController.m (modified) (2 diffs)

trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEServicePrefController.m

@@ -8 +8 @@
 
 #import "ICeCoffEEShared.h"
+#import "ICeCoffEESetServicesMenu.h"
 #import "ICeCoffEEServicePrefController.h"
 #import "ICeCoffEENonHighlightingButtonCell.h"
@@ -222 +223 @@
 {
     if (servicesMenu == nil) {
-        servicesMenu = [[NSMenu alloc] initWithTitle: @""];
-        [[NSApplication sharedApplication] setServicesMenu: servicesMenu];
-        [servicesMenu update];
+        servicesMenu = [[NSMenu alloc] initWithTitle: @""];
+        ICCF_SetServicesMenu(servicesMenu);
+        [servicesMenu update]; // XXX necessary on 10.3? or anywhere?
         NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
         NSDictionary *icDefaults = [defaults persistentDomainForName: (NSString *)kICBundleIdentifier];