Changeset 106 for trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEWebKit.m

Timestamp:

03/08/03 03:15:01 (21 years ago)

Author:

Nicholas Riley

Message:

ICeCoffEE 1.3.2b1

File:

• trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEWebKit.m (modified) (3 diffs)

trunk/ICeCoffEE/ICeCoffEE/ICeCoffEEWebKit.m

@@ -83 +83 @@
         WebCoreBridge *bridge = [(WebHTMLView *)self _bridge];
         ICCF_GetWebCoreBridgeSelection(bridge, &selection);
+        ICLog(@"selection start %d@%@ end %d@%@ string %@", [bridge selectionStartOffset], [bridge selectionStart], [bridge selectionEndOffset], [bridge selectionEnd], [bridge selectedString]);
         // XXX hack until we have something better
         [selectedString release]; selectedString = nil;
@@ -117 +118 @@
             // XXX works, but doesn't update
             ICCF_StartIC();
-            ICCF_LaunchURL(selectedString, ICCF_OptionKeyIsDown());
+            ICCF_LaunchURL(selectedString, ICCF_KeyboardAction());
+            // breaks in Safari v62 and before
             ICCF_SetWebCoreBridgeSelection(bridge, &selection);
             if (ICCF_prefs.textBlinkEnabled) {
@@ -133 +135 @@
 
         ICCF_StopIC();
+        // XXX need to release fromNode, toNode
 
-        // ICLog(@"selection start %d end %d string %@", [bridge selectionStartOffset], [bridge selectionEndOffset], [bridge selectedString]);
         // [bridge forceLayout];
         // ICLog(@"force start %d end %d string %@", [bridge selectionStartOffset], [bridge selectionEndOffset], [bridge selectedString]);